Check if templating engine supports given view #40373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ControllerTrait::render
andControllerTrait::renderView
methods assume that when thetemplating
service is available it can always render the given view via that service.However, that might not be the case. For example if
framework.templating
is not configured to support thetwig
engine for example but only some other custom engine, e.g.it will fail when the given view references a Twig template for instance and the configured engine cannot render that.
The
Symfony\Component\Templating\EngineInterface
whichtemplating
implements defines asupport
method:symfony/src/Symfony/Component/Templating/EngineInterface.php
Lines 56 to 63 in 2536e17
which should be used here, in order to make sure that
templating
actually does support rendering the given view.