fix parsing calls of methods named "method"

symfony · derrabus · Mar 3, 2021 · Mar 3, 2021 · Mar 3, 2021 · a9de390676996fbebdce6be1e9754b7f2d4e62ab
commit a9de390676996fbebdce6be1e9754b7f2d4e62ab
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -471,7 +471,7 @@ private function parseDefinition(string $id, $service, string $file, array $defa
                    throw new InvalidArgumentException(sprintf('Invalid method call for service "%s", did you forgot a leading dash before "%s: ..." in "%s"?', $id, $k, $file));
                }

-                if (isset($call['method'])) {
+                if (isset($call['method']) && \is_string($call['method'])) {
                    $method = $call['method'];
                    $args = $call['arguments'] ?? [];
                    $returnsClone = $call['returns_clone'] ?? false;

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/alt_call.yaml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/alt_call.yaml
@@ -3,3 +3,5 @@ services:
        calls:
            - foo: [1, 2, 3]
            - bar: !returns_clone [1, 2, 3]
+            - method:
+                  - url
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php
@@ -968,6 +968,7 @@ public function testAlternativeMethodCalls()
        $expected = [
            ['foo', [1, 2, 3]],
            ['bar', [1, 2, 3], true],
+            ['method', ['url']],
        ];

        $this->assertSame($expected, $container->getDefinition('foo')->getMethodCalls());