[FrameworkBundle] Fix PropertyAccess definition when not in debug #40313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
derrabus
approved these changes
Feb 28, 2021
nicolas-grekas
approved these changes
Mar 9, 2021
fabpot
approved these changes
Mar 9, 2021
|
Thank you @PedroTroller. |
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 11, 2021
…n not in debug (PedroTroller) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fix PropertyAccess definition when not in debug | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT The signature of the `PropertyAccessor::createCache()` method specifies that the first argument must be a string but in the `FameworkBundle` configures its DIC with a first argument to `null`. Replacing `null` by `''` allows to respect the contact of `PropertyAccessor::createCache()` and removes the following error when the `symfony/framework-bundle` is blocked in `4.4` but the symfony/property-access goes up to `5.2`. ``` Argument 3 passed to Symfony\Component\PropertyAccess\PropertyAccessor::createCache() must be of the type string, null given, called in /usr/src/app/var/cache/prod/ContainerDX7KWI4/getCache_PropertyAccessService.php on line 12 ``` Commits ------- 116c54a Fix FrameworkBundle PropertyAccess definition when not in debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the
PropertyAccessor::createCache()method specifies that the first argument must be a string but in theFrameworkBundleconfigures its DIC with a first argument tonull. Replacingnullby''allows to respect the contact ofPropertyAccessor::createCache()and removes the following error when thesymfony/framework-bundleis blocked in4.4but the symfony/property-access goes up to5.2.