[FrameworkBundle][Translator] scan directories for translations sequentially #40116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 6, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #40014 |
| License | MIT |
| Doc PR |
05bce3a to
29c971c
Compare
jderusse
previously approved these changes
Feb 6, 2021
rheh
reviewed
Feb 6, 2021
| ->sortByName() | ||
| ; | ||
| foreach ($finder as $file) { | ||
| $fileNameParts = explode('.', basename($file)); |
There was a problem hiding this comment.
Is there a reason for using basename over $file->getBasename()?
| ; | ||
| foreach ($finder as $file) { | ||
| $fileNameParts = explode('.', basename($file)); | ||
| $locale = $fileNameParts[\count($fileNameParts) - 2]; |
There was a problem hiding this comment.
Suggestion : Wouldn't $info->getBasename($info->getExtension())) give us the locale? Assuming the filer is only matching patterns such as 'ar.json'? I would remove the need for the explode and fileparts?
There was a problem hiding this comment.
That code was here before. I suggest not to change it as part of this bugfix.
|
@jderusse test added |
jderusse
approved these changes
Feb 7, 2021
nicolas-grekas
approved these changes
Feb 7, 2021
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.