Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Translation] XliffLintCommand supports Github Actions annotations #39828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2021
Merged

[Translation] XliffLintCommand supports Github Actions annotations #39828

merged 1 commit into from
Jul 25, 2021

Conversation

YaFou
Copy link
Contributor

@YaFou YaFou commented Jan 14, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #39122 (for lint:xliff)
License MIT
Doc PR TODO

Adds a format to the XLIFF linter command to print Github Actions annotations when an error occurred (documentation). There is a new format: github and the command will detect automatically the format to use in comparison with the environment.

See a workflow example: https://github.com/YaFou/symfony-39828/actions/runs/485142330

TODO:

  • Test with a real project

@carsonbot carsonbot changed the title [Translation] XliffLintCommand supports Github Actions annotations [Translator] XliffLintCommand supports Github Actions annotations Jan 14, 2021
@YaFou YaFou force-pushed the github-xliff-lint-command branch from 3d2b9b9 to c462e3e Compare January 14, 2021 10:45
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Jan 14, 2021
@YaFou YaFou mentioned this pull request Jan 14, 2021
Closed
2 tasks
@YaFou YaFou force-pushed the github-xliff-lint-command branch from c462e3e to 88b83f5 Compare January 14, 2021 20:59
@YaFou YaFou force-pushed the github-xliff-lint-command branch from 88b83f5 to 8183d44 Compare January 15, 2021 06:36
@YaFou YaFou force-pushed the github-xliff-lint-command branch 3 times, most recently from 433ff8c to dbc2fca Compare May 27, 2021 07:59
@YaFou YaFou requested review from jderusse and OskarStark May 27, 2021 08:11
@carsonbot carsonbot changed the title [Translator] XliffLintCommand supports Github Actions annotations [Translation] XliffLintCommand supports Github Actions annotations Jul 25, 2021
@fabpot fabpot force-pushed the github-xliff-lint-command branch from dbc2fca to 8ac2b2a Compare July 25, 2021 15:20
@fabpot
Copy link
Member

fabpot commented Jul 25, 2021

Thank you @YaFou.

@fabpot fabpot mentioned this pull request Jul 25, 2021
Closed
@fabpot fabpot merged commit aebe81b into symfony:5.4 Jul 25, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse Awaiting requested review from jderusse

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Feature Status: Reviewed Translation
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

Add Github annotations support to all linters
6 participants
@YaFou @fabpot @jderusse @OskarStark @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.