Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Lock] Add LockFactoryInterface #39634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[Lock] Add LockFactoryInterface #39634

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6786e44
[Lock] Add LockFactoryInterface
Nyholm Dec 27, 2020
c30a6c5
CS
Nyholm Dec 27, 2020
eea6117
Update DI aliases
Nyholm Dec 27, 2020
57230df
cs
Nyholm Dec 27, 2020
816acfb
Small changes
Nyholm Dec 27, 2020
18207f7
Added upgrade docs
Nyholm Dec 28, 2020
32727d3
Update lock changelog
Nyholm Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cs
  • Loading branch information
@Nyholm
Nyholm committed Dec 27, 2020
commit 57230df8d6cf79f7e96a256e4abd02cfa80e6ab8
4 changes: 2 additions & 2 deletions 4 src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,7 +1709,7 @@ private function registerLockConfiguration(array $config, ContainerBuilder $cont
$container->setAlias('lock.factory', new Alias('lock.'.$resourceName.'.factory', false));
$container->setAlias(LockFactoryInterface::class, new Alias('lock.factory', false));

$deprecationMessage = 'The "%alias_id%" alias is deprecated, use "' . LockFactoryInterface::class . '" instead.';
$deprecationMessage = 'The "%alias_id%" alias is deprecated, use "'.LockFactoryInterface::class.'" instead.';
$container->setAlias('lock.store', (new Alias($storeDefinitionId, false))->setDeprecated('symfony/framework-bundle', '5.2', $deprecationMessage));
$container->setAlias('lock', (new Alias('lock.'.$resourceName, false))->setDeprecated('symfony/framework-bundle', '5.2', $deprecationMessage));
$container->setAlias(PersistingStoreInterface::class, (new Alias($storeDefinitionId, false))->setDeprecated('symfony/framework-bundle', '5.2', $deprecationMessage));
Expand All @@ -1718,7 +1718,7 @@ private function registerLockConfiguration(array $config, ContainerBuilder $cont
} else {
$container->registerAliasForArgument('lock.'.$resourceName.'.factory', LockFactoryInterface::class, $resourceName.'.lock.factory');

$deprecationMessage = 'The "%alias_id%" alias is deprecated, use "' . LockFactoryInterface::class . ' $' . $resourceName . 'LockFactory" instead.';
$deprecationMessage = 'The "%alias_id%" alias is deprecated, use "'.LockFactoryInterface::class.' $'.$resourceName.'LockFactory" instead.';
$container->registerAliasForArgument($storeDefinitionId, PersistingStoreInterface::class, $resourceName.'.lock.store')->setDeprecated('symfony/framework-bundle', '5.2', $deprecationMessage);
$container->registerAliasForArgument('lock.'.$resourceName.'.factory', LockFactory::class, $resourceName.'.lock.factory')->setDeprecated('symfony/framework-bundle', '5.3', $deprecationMessage);
$container->registerAliasForArgument('lock.'.$resourceName, LockInterface::class, $resourceName.'.lock')->setDeprecated('symfony/framework-bundle', '5.2', $deprecationMessage);
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Symfony/Bundle/FrameworkBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"symfony/dom-crawler": "<4.4",
"symfony/http-client": "<4.4",
"symfony/form": "<5.2",
"symfony/lock": "<4.4",
"symfony/lock": "<5.3",
Nyholm marked this conversation as resolved.
Show resolved Hide resolved
"symfony/mailer": "<5.2",
"symfony/messenger": "<4.4",
"symfony/mime": "<4.4",
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.