CS: Apply ternary_to_null_coalescing fixer #39632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 27, 2020
| @@ -17,6 +17,7 @@ return PhpCsFixer\Config::create() | ||
| 'combine_nested_dirname' => true, | ||
| 'list_syntax' => ['syntax' => 'short'], | ||
| 'visibility_required' => ['property', 'method', 'const'], | ||
| 'ternary_to_null_coalescing' => true, |
There was a problem hiding this comment.
This should then be added to the @symfony ruleset of pho-cs-fixer, too
There was a problem hiding this comment.
folks, do not hesitate to raise PR for Fixer repo ;)
nicolas-grekas
approved these changes
Dec 27, 2020
|
The branches are in sync at the moment. Looks like a good moment to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't need to support PHP 5 anymore, we can upgrade our older code to use the null coalescing operator and enforce its usage through our PHP CS Fixer configuration. I think, the usage of that operator improves the readability of our codebase at lot.
Note that the changes in this PR are (with the exception of
.php_cs.dist) completely automated. You should get the same results by running the following command (and reverting the changes to PhpUnitBridge afterwards).php-cs-fixer fix --rules='{"ternary_to_null_coalescing":true}' src