[Notifier] Bump conflict rules for all notifier bridges #39559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Dec 18, 2020
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
|
What about removing all of them actually? |
|
We have already released version 5.2.0 of the bridges that claim compatibility with Notifier 5.3. |
|
I don't like them either, but imho we should not remove them before 6.0. Otherwise, we would allow Composer to make a bad decision. |
|
Then shouldn't we specifically conflit with the only bridges that have a 5.2.0 tag? |
be6fea7 to
fed253b
Compare
All of the bridges listed here existed in 5.2 already. Note that for some of the bridges, the 5.1.0, 5.1.1 and 5.1.2 tags are also affected. |
nicolas-grekas
approved these changes
Dec 18, 2020
|
I agree. 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.