Remove void return type from test methods #39459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Dec 11, 2020
|
For my information, why this change? For consistency? Can it be enforced with fabbot? Appear in https://symfony.com/doc/current/contributing/code/standards.html? Note that I'm only asking this because I blindly added |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 11, 2020
This PR was merged into the 5.1 branch. Discussion ---------- Remove void return type from test methods | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- This PR follows #39459 cc @nicolas-grekas Commits ------- 6e6c3ba Remove void return type from test methods
|
Tests don't define any API, so there is no need to define the signature of test cases. Removing void is then pure visual cleanups. CS basically yes. |
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nicolas-grekas