[Messenger] Use "warning" instead of "error" log level for RecoverableException #39378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Dec 8, 2020
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Outdated
Show resolved
Hide resolved
4b54d1d to
1b6e420
Compare
stof
reviewed
Dec 8, 2020
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Outdated
Show resolved
Hide resolved
1b6e420 to
a885ba8
Compare
ogizanagi
reviewed
Dec 9, 2020
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Show resolved
Hide resolved
fabpot
approved these changes
Dec 10, 2020
|
Thank you @lyrixx. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one throw a
RecoverableExceptionInterface, one knows somethingswrong occurs, so if an
errorshould be emmited, it's in place where theexception is thrown.
And, by extension, if nothing really wrong occurs (like a random network
error), one may want to retry the message without any errors.
That's why in this PR, if an exception of type
RecoverableExceptionInterfaceis thrown, it uses
warninginsteand oferrorlog level. Soeverything stay under the radar.