Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Notifier] Add ContextBlock for slack notifier #39258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

[Notifier] Add ContextBlock for slack notifier #39258

merged 1 commit into from
Dec 5, 2020

Conversation

norkunas
Copy link
Contributor

@norkunas norkunas commented Dec 1, 2020

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This block allows to add small text to the message layout footer

@norkunas norkunas force-pushed the slack-context-block branch from 4c8bade to c16c185 Compare December 1, 2020 05:21
jderusse
jderusse reviewed Dec 1, 2020
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackContextBlock.php Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackContextBlock.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackContextBlock.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackContextBlock.php Outdated Show resolved Hide resolved
@norkunas norkunas force-pushed the slack-context-block branch 2 times, most recently from a58cbd7 to bfb2cdb Compare December 1, 2020 06:28
@norkunas norkunas force-pushed the slack-context-block branch from bfb2cdb to 00ed0bb Compare December 1, 2020 06:35
@norkunas norkunas force-pushed the slack-context-block branch from 00ed0bb to 6687e23 Compare December 1, 2020 06:49
@jderusse jderusse added this to the 5.x milestone Dec 4, 2020
fabpot
fabpot approved these changes Dec 5, 2020
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackContextBlock.php
* file that was distributed with this source code.
*/

declare(strict_types=1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed as we don't use it in Symfony.

@fabpot
Copy link
Member

fabpot commented Dec 5, 2020

Thank you @norkunas.

@fabpot fabpot mentioned this pull request Dec 5, 2020
Closed
@fabpot fabpot merged commit bb0362d into symfony:5.x Dec 5, 2020
@norkunas norkunas deleted the slack-context-block branch December 5, 2020 07:16
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@norkunas @fabpot @jderusse @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.