[Notifier] Fix slack section block #39236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test? |
d67ce73 to
f798e57
Compare
Sure, added. |
f798e57 to
0efb504
Compare
derrabus
reviewed
Nov 30, 2020
src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackSectionBlockTest.php
Outdated
Show resolved
Hide resolved
0efb504 to
472fa3b
Compare
derrabus
approved these changes
Nov 30, 2020
fabpot
approved these changes
Dec 2, 2020
|
Thank you @norkunas. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2020
…k action block (malteschlueter) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Check for maximum number of buttons in slack action block | Q | A | ------------- | --- | Branch? | 5.x | | Bug fix? | no | | New feature? | yes | | Deprecations? | no | | Tickets | - | | License | MIT | | Doc PR | - | After having problems with the SlackSectionBlock (#39236) i thought it would be helpful to also have a check for the maximum elements in the SlackActionsBlock and a test. https://api.slack.com/reference/block-kit/blocks#actions Edit: The actual documentation says that the maximum are 5 elements but this is outdated. The actual number is 25. The slack support confirmed that. Can this be added to 5.2 or better to the 5.x branch? There are also some other implementations of slack blocks like the SlackDividerBlock but they have only a constructor and no additional methods. Should we also add some tests for them even if they have no extra logic? Commits ------- a7936d2 [Notifier] Check for maximum number of buttons in slack action block
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SlackSectionBlock fields array is not initialized directly in the constructor so when running tests and trying to add a field to it throws
Undefined index: fields.