Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DoctrineBridge] Fix form EntityType with filter on UID #39210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

[DoctrineBridge] Fix form EntityType with filter on UID #39210

merged 1 commit into from
Nov 28, 2020

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39207
License MIT
Doc PR -

Convert UUID and ULID to the right format in ORMQueryBuilder

/cc @nicolas-grekas

@jderusse jderusse changed the base branch from 5.x to 5.2 November 28, 2020 11:42
@jderusse jderusse added this to the 5.2 milestone Nov 28, 2020
@jderusse jderusse changed the title [DoctrineBridge] Fix form EntotyType with uid [DoctrineBridge] Fix form EntityType with filter on UID Nov 28, 2020
nicolas-grekas
nicolas-grekas reviewed Nov 28, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
LGTM, once tests are green

src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php Outdated Show resolved Hide resolved
nicolas-grekas
nicolas-grekas approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jderusse

@nicolas-grekas nicolas-grekas merged commit 0c285d1 into symfony:5.2 Nov 28, 2020
@colinodell
Copy link
Contributor

Thanks for the quick fix!

@fabpot fabpot mentioned this pull request Nov 30, 2020
Merged
@jderusse jderusse deleted the uid-form branch December 9, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-demb andrew-demb andrew-demb left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[DoctrineBridge] ORMQueryBuilderLoader not compatible with binary UUID columns
5 participants
@jderusse @colinodell @nicolas-grekas @andrew-demb @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.