[Validator] Allow load mappings from attributes without doctrine/annotations #39032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d90b6d to
3ba49bf
Compare
jderusse
reviewed
Nov 7, 2020
3ba49bf to
441c806
Compare
fabpot
approved these changes
Nov 8, 2020
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #38309.
Currently, we cannot enable constraint mapping from attributes without having
doctrine/annotationsinstalled. Lifting that limitation is a bit tricky becauseValidatorBuilder::enableAnnotationMapping()creates an annotation reader if you don't pass one. This PR aims at deprecating this behavior.I know it's a bit late for such a change in 5.2 and I should have seen earlier that this part was missing. 😓 Since I don't expect people to go all-in on attributes on day one, it's probably okay to postpone this change to 5.3.