-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Missing translations for Chinese (zh_TW) #38733 #38848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
I appreciate your work.
Thank you.
I just have some comments.
</trans-unit> | ||
<trans-unit id="113"> | ||
<source>Please select a valid locale.</source> | ||
<target>請選擇有效的地區。</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, does it say "locale"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,i will change it to "請選擇有效的语言环境" 。
</trans-unit> | ||
<trans-unit id="114"> | ||
<source>Please enter a valid money amount.</source> | ||
<target>請輸入正確的金額。</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This google translates to "please enter the correct amount", it should be "valid". Can you double check if this is correct? (Or if Google is wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, i'm not so sure about this cause the chinese word "正确" can be seen as "correct" or "valid" in english. But to me, this is not wrong and the google translates is not wrong as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or i stick to google translates, i change it to "有效" instead of "正确"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do what sounds best.
I just wanted to make sure you didn't accidentally made a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, so far so good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
e964369
to
3e741fd
Compare
Thank you @fd6130. |
Added missing translations for zh_TW in Form, Security, Validator.