Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Missing translations for Chinese (zh_TW) #38733 #38848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

fd6130
Copy link
Contributor

@fd6130 fd6130 commented Oct 27, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38733
License MIT

Added missing translations for zh_TW in Form, Security, Validator.

@fd6130 fd6130 requested a review from xabbuh as a code owner October 27, 2020 18:06
@carsonbot carsonbot added this to the 3.4 milestone Oct 27, 2020
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
I appreciate your work.

Thank you.

I just have some comments.

</trans-unit>
<trans-unit id="113">
<source>Please select a valid locale.</source>
<target>請選擇有效的地區。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, does it say "locale"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,i will change it to "請選擇有效的语言环境" 。

</trans-unit>
<trans-unit id="114">
<source>Please enter a valid money amount.</source>
<target>請輸入正確的金額。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This google translates to "please enter the correct amount", it should be "valid". Can you double check if this is correct? (Or if Google is wrong)

Copy link
Contributor Author

@fd6130 fd6130 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i'm not so sure about this cause the chinese word "正确" can be seen as "correct" or "valid" in english. But to me, this is not wrong and the google translates is not wrong as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or i stick to google translates, i change it to "有效" instead of "正确"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do what sounds best.

I just wanted to make sure you didn't accidentally made a mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so far so good.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@fabpot fabpot force-pushed the zh_TW_translation branch from e964369 to 3e741fd Compare October 28, 2020 05:23
@fabpot
Copy link
Member

fabpot commented Oct 28, 2020

Thank you @fd6130.

@fabpot fabpot merged commit 8c6b652 into symfony:3.4 Oct 28, 2020
@fd6130 fd6130 deleted the zh_TW_translation branch October 16, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.