Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Display php info for extra versions in travis #38826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Oct 26, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Display the PHP info of all tested versions when the test-suite use several versions of PHP

Helps to troubleshoot #38818 (comment)

@Nyholm
Copy link
Member

Nyholm commented Oct 26, 2020

I've found info outputs like this super helpful in my CI. I do them for PHP versions and versions of static tools.

@nicolas-grekas
Copy link
Member

Unrelated to the issue, here is the fix: 255f1e3

@jderusse
Copy link
Member Author

Hm I never said this PR was fixing the linked issue.

Displaying the info of PHP 7.2, when running the "5.6 + 7.0 + 7.1 + 7.2" test-suite is useless.
The purpose of this PR was to display the PHP info of all tested versions (and not only the last version)

If we don't need this, then I suggest to remove this step.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 26, 2020
@jderusse
Copy link
Member Author

Please don't merge it before CI green. I'm not 100% confident with the syntax

@jderusse jderusse marked this pull request as draft October 26, 2020 16:50
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit cc1cb85 into symfony:3.4 Oct 27, 2020
@jderusse jderusse deleted the test-phpi branch October 27, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.