[DI] Fix Preloader exception when preloading a class with an unknown parent/interface #38713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check if this problem exists on 4.4 as well? If yes, we need to fix it there. |
derrabus
requested changes
Oct 25, 2020
src/Symfony/Component/DependencyInjection/Tests/Dumper/PreloaderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/Preload/DummyWithInterface.php
Outdated
Show resolved
Hide resolved
Can you rebase your changes on 4.4 then? If not, that's okay as well. I can do that while merging. |
|
Oh, and thank you very much for your PR, of course. 😃 |
7059fae to
173fa68
Compare
I rebased it now. Will you port the fix to 5.1 then? |
derrabus
approved these changes
Oct 25, 2020
The branches are merged periodically. Changes merged to the 4.4 branch will also be shipped with the next 5.1 release. |
nicolas-grekas
approved these changes
Oct 27, 2020
173fa68 to
b6ae485
Compare
|
Thank you @rgeraads. |
This was referenced Oct 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Preloader exception when preloading a class with an unknown parent/interface.