[PhpUnitBridge] Support new expect methods in test case polyfill #38680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
c1cf6b8 to
d36157e
Compare
nicolas-grekas
approved these changes
Oct 22, 2020
…o TestCase polyfill
d36157e to
8a49a26
Compare
|
We consider such changes as bugfixes (see #37970 for bg) |
fabpot
approved these changes
Oct 23, 2020
|
Thank you @alcaeus. |
This was referenced Oct 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
expectError,expectWarning,expectNotice,andmethods to the test case polyfill.expectDeprecationNote that I saw aexpectDeprecationmessage inExpectDeprecationTrait, but I couldn't quite figure out what it's supposed to do. Please let me know if theexpectDeprecationmethod needs to be removed from the test polyfill.