[BrowserKit] Allowing body content from GET with a content-type #38622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47fc11a to
d14adac
Compare
|
I tried to make sense of Appveyor details but couldn't determine why it failed. |
stloyd
reviewed
Oct 19, 2020
nicolas-grekas
approved these changes
Oct 19, 2020
|
Im happy with this PR after @stloyd's change. |
|
@nicolas-grekas That's for 5.x :) |
|
Thanks @stloyd for your suggestion! I've committed the changes you've suggested. |
jderusse
reviewed
Oct 20, 2020
21637cd to
a054362
Compare
|
Please, let me know if this is failing because of my changes. From what I saw, I don't think it was. |
a054362 to
93c2f5e
Compare
|
Thank you @thiagomp. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a GET request to sent a payload if it specifies a content-type in the HTTP header as per our conversation in the ticket.