Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpClient] fix using proxies with NativeHttpClient #38375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

[HttpClient] fix using proxies with NativeHttpClient #38375

merged 1 commit into from
Oct 2, 2020

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 1, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As spotted by @stof in #38368 (comment), we cannot use local DNS resolution with HTTP proxies.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Oct 1, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 1, 2020
Merged
@bohanyang
Copy link
Contributor

Thank you. This time it worked correctly with both privoxy and v2ray.

@nicolas-grekas nicolas-grekas force-pushed the hc-native+proxy branch 5 times, most recently from bffd91f to c5e4302 Compare October 2, 2020 07:55
@nicolas-grekas nicolas-grekas force-pushed the hc-native+proxy branch 2 times, most recently from 639ba05 to 8310428 Compare October 2, 2020 08:11
@nicolas-grekas nicolas-grekas merged commit aca260f into symfony:4.4 Oct 2, 2020
@nicolas-grekas nicolas-grekas deleted the hc-native+proxy branch October 2, 2020 08:30
@bohanyang
Copy link
Contributor

bohanyang commented Oct 2, 2020 •
edited
Loading

Sorry, I tested again with the merged code, the SSL peer name verification is broken

PHP Fatal error:  Uncaught Symfony\Component\HttpClient\Exception\TransportException: fopen(): Peer certificate CN=`random.org' did not match expected CN=`'
PHP Fatal error:  Uncaught Symfony\Component\HttpClient\Exception\TransportException: fopen(): SSL operation failed with code 1. OpenSSL Error messages:
error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed

image

@nicolas-grekas nicolas-grekas mentioned this pull request Oct 2, 2020
Merged
nicolas-grekas added a commit that referenced this pull request Oct 2, 2020
@nicolas-grekas
minor #38379 [HttpClient] fix unsetting context[ssl][peer_name] (nico…
7187539 
…las-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix unsetting context[ssl][peer_name]

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no (fixing a not released fix)
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38375 (comment)
| License       | MIT
| Doc PR        | -

/cc @bohanyang could you please confirm this fixes it?

Commits
-------

8eb8a7c [HttpClient] fix unsetting context[ssl][peer_name]
This was referenced Oct 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @bohanyang @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.