Revert "bug #38063 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable" #38343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2020
chalasr
approved these changes
Sep 29, 2020
yceruto
approved these changes
Sep 29, 2020
derrabus
approved these changes
Sep 29, 2020
fabpot
approved these changes
Sep 30, 2020
|
Thank you @nicolas-grekas. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 1, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead. Discussion ---------- Update location of preloading file Follows symfony/symfony#38343 and symfony/recipes#825 Commits ------- 8213d9c Update location of preloading file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the linked issue, let's replace this with a recipe:
symfony/recipes#825
TL;DR, these PRs replace
src/.preload.php(generated) byconfig/preload.php(committed).