[DI] dump OS-indepent paths in the compiled container #38139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
280a024 to
f0869a8
Compare
f0869a8 to
4dcf9e7
Compare
|
Thank you @nicolas-grekas. |
stof
reviewed
Sep 10, 2020
| @@ -233,7 +233,7 @@ public function testDumpAsFiles() | ||
| $dumper = new PhpDumper($container); | ||
| $dump = print_r($dumper->dump(['as_files' => true, 'file' => __DIR__, 'hot_path_tag' => 'hot']), true); | ||
| if ('\\' === \DIRECTORY_SEPARATOR) { | ||
| $dump = str_replace('\\\\Fixtures\\\\includes\\\\foo.php', '/Fixtures/includes/foo.php', $dump); | ||
| $dump = str_replace("'.\\DIRECTORY_SEPARATOR.'", '/', $dump); |
There was a problem hiding this comment.
why this replacement here rather than updating the fixture to contain the OS-independent output (which would allow to see that it is actually generated) ?
There was a problem hiding this comment.
Well, the output is not OS-independent: the paths are.
On Windows, \ are turned into DIRECTORY_SEPARATOR
On Linux, / are kept as is (and they work on Windows as you know)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compiling on Windows and running on Linux (Docker).