Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Console] guard $argv + $token against null, preventing unnecessary exceptions #38114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

bilogic
Copy link

@bilogic bilogic commented Sep 8, 2020

Q A
Branch? 3.4
Bug fix? yes
Tickets Fix #38105
License MIT

This issue was causing an unnecessary exception, leading to difficulty in locating the actual offending code as reported by many cases as detailed in #38105

@nicolas-grekas nicolas-grekas changed the title guard $argv + $token against null, preventing unnecessary exceptions [Console] guard $argv + $token against null, preventing unnecessary exceptions Sep 8, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Sep 8, 2020
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 3.4 September 8, 2020 20:57
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 3.4 Sep 8, 2020
@nicolas-grekas
Copy link
Member

Thank you @bilogic.

@nicolas-grekas nicolas-grekas merged commit 68866fb into symfony:3.4 Sep 8, 2020
@xabbuh xabbuh added the Console label Sep 9, 2020
This was referenced Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.