Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Intl] Skip test cases that produce a TypeError on php 8 #38072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 5, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

On php 8, NumberFormatter::setAttribute() will throw a type error if the provided value is not of type int|float. This is why I'm skipping the corresponding tests for now. Alternatively, we could check for the PHP version in Symfony's implementation of that class and throw the TypeError as well, if we're on php 8. But since this is a breaking change, I'm was unsure if I sould go that way.

@fabpot
Copy link
Member

fabpot commented Sep 5, 2020

Thank you @derrabus.

@fabpot fabpot merged commit ede0a12 into symfony:3.4 Sep 5, 2020
@derrabus derrabus deleted the bugfix/stricter-intl branch September 5, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.