[PHPUnitBridge] Fix deprecation type detection when trigger_deprecation is used #38013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5750b22 to
92d4a84
Compare
| $backtraceTriggerDeprecation = $trace[2] ?? null; | ||
| if ($backtraceTriggerDeprecation && 'trigger_deprecation' === $backtraceTriggerDeprecation['function']) { | ||
| $file = $backtraceTriggerDeprecation['file']; | ||
| unset($trace[1]); |
There was a problem hiding this comment.
can be removed if array_values() is removed below, isn't it? that would save some memcopies.
There was a problem hiding this comment.
I'm not sure to understand properly. unset is not here because of array_values, it's array_values that is needed because of unset. And unset is needed since if I keep the trace of deprecations-contracts/functions.php file, deprecations-contracts/functions.php is considered to determine direct and indirect deprecations instead of the file that call trigger_deprecation.
92d4a84 to
fd39961
Compare
nicolas-grekas
approved these changes
Sep 2, 2020
|
Thank you @l-vo. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trigger_deprecation is used, the deprecation types (self, direct, indirect) are not properly detected because the file where the deprecation come from is always
deprecation-contracts/functions.php. This PR aims to fix that.