Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Serializer] Fix that it will never reach DOMNode #37701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

TNAJanssen
Copy link
Contributor

@TNAJanssen TNAJanssen commented Jul 29, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT
Doc PR

When providing the DOMNode object, the is_object check will return true. This way it will never reach the DOMNode check.

So i moved this check to above the is_object check.

@nicolas-grekas
Copy link
Member

Could you please add a test case?

@TNAJanssen
Copy link
Contributor Author

Sure, will do that on monday:)

@fabpot
Copy link
Member

fabpot commented Aug 4, 2020

Thank you @TNAJanssen.

@fabpot fabpot merged commit 995d784 into symfony:3.4 Aug 4, 2020
This was referenced Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.