Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix author for class CachePoolClearerCacheWarmer #37517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix author for class CachePoolClearerCacheWarmer #37517

merged 1 commit into from
Jul 29, 2020

Conversation

guilliamxavier
Copy link
Contributor

@guilliamxavier guilliamxavier commented Jul 7, 2020

Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #35109 (comment)
License MIT
Doc PR symfony/symfony-docs#...

@guilliamxavier
Copy link
Contributor Author

/cc @teohhanhui for approval

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Jul 9, 2020
@nicolas-grekas nicolas-grekas removed the Bug label Jul 9, 2020
@nicolas-grekas
Copy link
Member

Closing as staled, we can reopen if the change is confirmed.

@guilliamxavier
Copy link
Contributor Author

/ping @bastnic

@teohhanhui
Copy link
Contributor

I can confirm I wrote the original class.

Sorry for the lack of response, I have stopped doing Symfony / API Platform, and moved on to Rust.

@bastnic
Copy link
Contributor

bastnic commented Jul 23, 2020

I can confirm @teohhanhui confirmation ;).

@xabbuh xabbuh reopened this Jul 23, 2020
@nicolas-grekas
Copy link
Member

Thank you @guilliamxavier.

@nicolas-grekas nicolas-grekas merged commit f03a4b3 into symfony:5.1 Jul 29, 2020
@guilliamxavier guilliamxavier deleted the patch-1 branch July 29, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.