Modified POEditor Provider to use xlf export

symfony · welcoMattic · Apr 26, 2020 · May 10, 2020 · Jun 29, 2020 · Jun 30, 2020
commit 26050f6b8c916000e869e85ef28823a5785c902d
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.php
@@ -79,9 +79,6 @@
        ->set('translator.formatter.default', MessageFormatter::class)
            ->args([service('identity_translator')])

-        ->set('translation.loader.array', ArrayLoader::class)
-            ->tag('translation.loader', ['alias' => 'array'])
-
        ->set('translation.loader.php', PhpFileLoader::class)
            ->tag('translation.loader', ['alias' => 'php'])


diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php
@@ -50,7 +50,7 @@

        ->set('translation.provider_factory.poeditor', PoEditorProviderFactory::class)
            ->args([
-                service('translation.loader.array'),
+                service('translation.loader.xliff_raw'),
            ])
            ->parent('translation.provider_factory.abstract')
            ->tag('translation.provider_factory')

diff --git a/src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php b/src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
@@ -93,12 +93,7 @@ public function read(array $domains, array $locales): TranslatorBag
                    'api_token' => $this->apiKey,
                    'id' => $this->projectId,
                    'language' => $locale,
-                    /*
-                     * POEditor XLF export not support Terms as <source>.
-                     * The source tag is either empty or equals to Default Language Reference translation.
-                     * This is why we have to export in json, parse it, and load it with ArrayLoader.
-                     */
-                    'type' => 'key_value_json',
+                    'type' => 'xlf',
                    'filters' => json_encode(['translated']),
                    'tags' => json_encode($domains),
                ],
@@ -114,18 +109,8 @@ public function read(array $domains, array $locales): TranslatorBag
                'headers' => $this->getDefaultHeaders(),
            ]);

-            $responseContent = json_decode($response->getContent(), true);
-
-            $content = [];
-
-            foreach ($responseContent as $translation) {
-                $content += $translation;
-            }
-
-            if ($responseContent) {
-                foreach ($domains as $domain) {
-                    $translatorBag->addCatalogue($this->loader->load($content, $locale, $domain));
-                }
+            foreach ($domains as $domain) {
+                $translatorBag->addCatalogue($this->loader->load($response->getContent(), $locale, $domain));
            }
        }