[Workflow] Added Function (and Twig extension) to retrieve a specific transition #37428
Conversation
7865422 to
f9074aa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f9074aa to
9a315b9
Compare
9a315b9 to
1f86a53
Compare
There was a problem hiding this comment.
Thanks for your contribution.
Instead of the current implementation, I would simplify a lot the code:
You could leverage the current getEnabledTransitions() method in the bridge, without implementing a new method.
Less code == less bug :)
@lyrixx That's actually what I did first (and that's what I currently do in my project). And then I thought it would make more sense to have a dedicated function... |
550d5de to
4001b15
Compare
|
Now, I have a problem with graphviz and PlantUML... Maybe I should not have changed the complex workflow ^^ |
4001b15 to
eb1de08
Compare
You can now easily retrieve a specific transition. Useful when you want the metadata of a specific transition.
eb1de08 to
9be8614
Compare
|
@lyrixx i updated the workflow changelog. |
|
The one in the bridge https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Twig/CHANGELOG.md |
|
@lyrixx Done ! |
c54b457 to
210048c
Compare
|
Thank you @epitre. |
…ieve a specific transition (Carlos Pereira De Amorim) This PR was squashed before being merged into the 5.2-dev branch. Discussion ---------- [Workflow] Added Function (and Twig extension) to retrieve a specific transition You can now easily retrieve a specific transition. Useful when you want the metadata of a specific transition. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | hmmmm, should I create a ticket first ? | License | MIT | Doc PR | symfony/symfony-docs#13907 I needed to get the metadata of a transition, but in order to do that, you need the transition object. So here is a PR to easily get the transition object Commits ------- 0eebe74 [Workflow] Added Function (and Twig extension) to retrieve a specific transition
You can now easily retrieve a specific transition. Useful when you want the metadata of a specific transition.
I needed to get the metadata of a transition, but in order to do that, you need the transition object. So here is a PR to easily get the transition object