[FrameworkBundle] preserve dots in query-string when redirecting #37271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9173d32 to
fc72937
Compare
nicolas-grekas
commented
Jun 13, 2020
| @@ -176,4 +186,49 @@ public function __invoke(Request $request): Response | ||
|
|
||
| throw new \RuntimeException(sprintf('The parameter "path" or "route" is required to configure the redirect action in "%s" routing configuration.', $request->attributes->get('_route'))); | ||
| } | ||
|
|
||
| private static function parseQueryString(string $qs) |
There was a problem hiding this comment.
this implementation should be replaced by #37272 when merging up to master (it's exactly the same)
fc72937 to
97a8df6
Compare
dunglas
approved these changes
Jun 17, 2020
gmponos
approved these changes
Jun 18, 2020
97a8df6 to
3d0d59d
Compare
|
Thank you @nicolas-grekas! |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #37270 to pass.