Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form] add missing Czech validators translation #36980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

[Form] add missing Czech validators translation #36980

merged 1 commit into from
May 28, 2020

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented May 27, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
License MIT

@mhujer mhujer requested a review from xabbuh as a code owner May 27, 2020 10:19
@xabbuh xabbuh added this to the 3.4 milestone May 27, 2020
@mhujer mhujer force-pushed the validators-update-czech branch from 18c91a0 to adbf4d0 Compare May 28, 2020 08:32
@mhujer mhujer changed the base branch from master to 5.1 May 28, 2020 08:32
@mhujer
Copy link
Contributor Author

mhujer commented May 28, 2020

@xabbuh This validator was added recently #36302 so I guess it won't be backported to 3.4, right? I rebased the branch 5.1 and changed to PR to target it.

@xabbuh
Copy link
Member

xabbuh commented May 28, 2020

@mhujer It's right that we don't backport new features, but for translations we try to minimise the effort needed for contributions and merge all translations into the oldest still maintained branch (3.4 right now).

@mhujer mhujer changed the base branch from 5.1 to 3.4 May 28, 2020 08:39
@mhujer mhujer force-pushed the validators-update-czech branch from adbf4d0 to afdda5d Compare May 28, 2020 08:40
javiereguiluz
javiereguiluz approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Verified with Google Translate 👍

@fabpot
Copy link
Member

fabpot commented May 28, 2020

Thank you @mhujer.

@fabpot fabpot merged commit 03cad5a into symfony:3.4 May 28, 2020
@mhujer mhujer deleted the validators-update-czech branch May 28, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@mhujer @xabbuh @fabpot @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.