[HttpClient] fix management of shorter-than-requested timeouts with AmpHttpClient #36960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cdf00b to
1ac069d
Compare
nicolas-grekas
commented
May 25, 2020
| Loop::cancel($delay); | ||
| } | ||
| while (true) { | ||
| self::$delay = Loop::delay(1000 * $remaining, [Loop::class, 'stop']); |
There was a problem hiding this comment.
@kelunik there is something I don't get here that you might want to check once this PR is merged. It looks like the delay defined here is not respected.
To see what I mean, checkout this PR, then add dump([$timeout, $remaining]); after the second "if" below, and run tests with ./phpunit src/Symfony/Component/HttpClient/ --filter Amp.*NotATimeout.
You'll see something like:
array:2 [
0 => 0.9
1 => 0.87336587905884
]
which means that the delay expired 0.87336587905884 seconds earlier than expected.
Do I miss something or could this be a bug in AMP's event loop?
There was a problem hiding this comment.
I've added two failing tests in amphp/amp#319, one of those is expected to fail, the other isn't.
fabpot
approved these changes
May 26, 2020
|
Thank you @nicolas-grekas. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 9, 2020
…Client (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [HttpClient] improve monitoring of timeouts with AmpHttpClient | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replaces #36960 Commits ------- 548818d [HttpClient] improve monitoring of timeouts with AmpHttpClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the most transient test in our CI, which was not a false positive.