[Validator] Make ExpressionLanguageSyntax validator usable with annotation #36886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @Andrej-in-ua |
jderusse
commented
May 20, 2020
| @@ -52,4 +52,13 @@ public function validate($expression, Constraint $constraint): void | ||
| ->addViolation(); | ||
| } | ||
| } | ||
|
|
||
| private function getExpressionLanguage(): ExpressionLanguage |
There was a problem hiding this comment.
inspired from
Guikingone
reviewed
May 21, 2020
src/Symfony/Component/Validator/Constraints/ExpressionLanguageSyntaxValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Constraints/ExpressionLanguageSyntaxValidator.php
Show resolved
Hide resolved
Andrej-in-ua
approved these changes
May 21, 2020
fabpot
approved these changes
May 22, 2020
|
Thank you @jderusse. |
This was referenced May 22, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new on an entity ExpressionLanguageSyntax (basicaly copy/pasted the sample from https://symfony.com/blog/new-in-symfony-5-1-expressionlanguage-validator), I face a first error:
indeed, the
serviceis need to generate a valide aliasWhich looks weird for a Constraint
This PR makes the ExpressionLanguage dependency optionnal in
ExpressionLanguageSyntaxValidator, and removes theservicethan is not needed anyore