Remove unnecesary catch in AuthenticationProviderManager #36822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These catch blocks are not equal and that is exactly why there is an
|
|
@wouterj the fact that Travis is green tells me that we don't have tests covering your expectation to prevent regressions. |
|
Oh, I see. But yes, the tests are passing. |
wouterj
added a commit
to wouterj/symfony
that referenced
this pull request
May 15, 2020
wouterj
added a commit
to wouterj/symfony
that referenced
this pull request
May 15, 2020
|
Agreed, proposed a test change in #36829 |
nicolas-grekas
added a commit
that referenced
this pull request
May 16, 2020
…havior (wouterj) This PR was merged into the 3.4 branch. Discussion ---------- [Security] Update test to test AccountStatusException behavior | Q | A | ------------- | --- | Branch? | 3.4 (behavior is this way since 2.0) | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - See #36822 This PR updates the `AccountStatusException` test to test the expected behavior of this exception (and its difference from `AuthenticationException`). Commits ------- 08fbfcf Added regression test for AccountStatusException behavior (ref #36822)
nicolas-grekas
added a commit
that referenced
this pull request
May 16, 2020
* 3.4: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref #36822) embed resource name in error message [Serializer] fix issue with PHP 8 [Yaml] Fix escaped quotes in quoted multi-line string
nicolas-grekas
added a commit
that referenced
this pull request
May 16, 2020
* 4.4: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref #36822) [HttpClient] fix PHP warning + accept status code >= 600 [Security/Core] fix compat of `NativePasswordEncoder` with pre-PHP74 values of `PASSWORD_*` consts embed resource name in error message [FrameworkBundle] fix stringable annotation Change priority of KernelEvents::RESPONSE subscriber Fix register event listeners compiler pass Missing description in `messenger:setup-transports` command [Serializer] fix issue with PHP 8 [WebProfiler] Remove 'none' when appending CSP tokens [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 [Yaml] Fix escaped quotes in quoted multi-line string
nicolas-grekas
added a commit
that referenced
this pull request
May 16, 2020
* 5.0: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref #36822) [HttpClient] fix PHP warning + accept status code >= 600 [Security/Core] fix compat of `NativePasswordEncoder` with pre-PHP74 values of `PASSWORD_*` consts embed resource name in error message [FrameworkBundle] fix stringable annotation Change priority of KernelEvents::RESPONSE subscriber Fix register event listeners compiler pass Missing description in `messenger:setup-transports` command [Serializer] fix issue with PHP 8 [WebProfiler] Remove 'none' when appending CSP tokens [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 [Yaml] Fix escaped quotes in quoted multi-line string
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
* 3.4: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref symfony#36822) embed resource name in error message [Serializer] fix issue with PHP 8 [Yaml] Fix escaped quotes in quoted multi-line string
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
* 4.4: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref symfony#36822) [HttpClient] fix PHP warning + accept status code >= 600 [Security/Core] fix compat of `NativePasswordEncoder` with pre-PHP74 values of `PASSWORD_*` consts embed resource name in error message [FrameworkBundle] fix stringable annotation Change priority of KernelEvents::RESPONSE subscriber Fix register event listeners compiler pass Missing description in `messenger:setup-transports` command [Serializer] fix issue with PHP 8 [WebProfiler] Remove 'none' when appending CSP tokens [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 [Yaml] Fix escaped quotes in quoted multi-line string
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
* 5.0: [VarDumper] fix for change in PHP 7.4.6 Added regression test for AccountStatusException behavior (ref symfony#36822) [HttpClient] fix PHP warning + accept status code >= 600 [Security/Core] fix compat of `NativePasswordEncoder` with pre-PHP74 values of `PASSWORD_*` consts embed resource name in error message [FrameworkBundle] fix stringable annotation Change priority of KernelEvents::RESPONSE subscriber Fix register event listeners compiler pass Missing description in `messenger:setup-transports` command [Serializer] fix issue with PHP 8 [WebProfiler] Remove 'none' when appending CSP tokens [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 [Yaml] Fix escaped quotes in quoted multi-line string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate catch is not needed as
AccountStatusException extends AuthenticationException.