Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Fix messenger:failed:remove can not remove single message #36660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

[Messenger] Fix messenger:failed:remove can not remove single message #36660

merged 1 commit into from
May 3, 2020

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented May 2, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36659
License MIT
Doc PR -

Fix this error:

count(): Parameter must be an array or an object that implements Countable

When calling messenger:failed:remove command from other code with single id

@tienvx tienvx requested a review from sroze as a code owner May 2, 2020 04:37
@tienvx
Copy link
Contributor Author

tienvx commented May 2, 2020

Related to #34980

@fabpot
Copy link
Member

fabpot commented May 2, 2020

I agree with @xabbuh that the fix is not correct. The id argument is declared as being an array, so an array must be passed. We could fix the validation of the arguments passed to the command when using an ArrayInput instead, that would be better.

@xabbuh
Copy link
Member

xabbuh commented May 2, 2020

I think I understand the issue now. We changed the type of the argument for 5.1. So the PR that introduced the possibility to specify more than one id broke BC.

@chalasr chalasr added this to the next milestone May 2, 2020
Nyholm
Nyholm approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is correct.

PR #34980 introduced a BC break to change the type from int to array. It was fine as long as you called the command from the CLI.

This PR is needed to avoid us releasing this BC break.

@fabpot
Copy link
Member

fabpot commented May 3, 2020

Thank you @tienvx.

@fabpot fabpot merged commit 87a5701 into symfony:master May 3, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@tienvx tienvx deleted the messenger-fix-remove-single-failed-message branch May 4, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@xabbuh xabbuh xabbuh approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Messenger] messenger:failed:remove can not remove single message
7 participants
@tienvx @fabpot @xabbuh @Nyholm @nicolas-grekas @chalasr @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.