Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Form annotation #36654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix Form annotation #36654

merged 1 commit into from
May 2, 2020

Conversation

VincentLanglet
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Symfony form component provide his own exception OutOfBoundsException which is implementing ExceptionInterface. Form are returning this custom OutOfBoundsException, but the phpDoc say it's an original \OutOfBoundsException, which is not extending the ExceptionInterface.

This can provide issue with static analysis tools.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 1, 2020
@xabbuh
Copy link
Member

xabbuh commented May 2, 2020

Thank you @VincentLanglet.

@xabbuh xabbuh merged commit d765a09 into symfony:3.4 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.