[Inflector] Fix testPluralize() arguments names #36639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Apr 30, 2020
| @@ -294,30 +294,30 @@ public function pluralizeProvider() | ||
| /** | ||
| * @dataProvider singularizeProvider | ||
| */ | ||
| public function testSingularize($plural, $singular) | ||
| public function testSingularize($plural, $expectedSingular) |
There was a problem hiding this comment.
Should I revert the changes on this method or backport it on 3.4?
javiereguiluz
approved these changes
May 3, 2020
fabpot
added a commit
that referenced
this pull request
May 4, 2020
… (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [3.4][Inflector] Improve testSingularize() argument name | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #36639 (comment) | License | MIT | Doc PR | - Follow up of #36639 on 3.4 to keep both tests methods synchronized. Commits ------- 7540524 [3.4][Inflector] Improve testSingularize() argument name
fabpot
approved these changes
May 4, 2020
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minor but the testPluralize() method arguments names are inversed ($plural contains the singular, $singular contains the plural, etc.). I lost some time on this because I thought the test was wrong 😅 I guess it's better to have a test that is easier to understand.