Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix form/data mapping for typehinted properties #36492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix form/data mapping for typehinted properties #36492

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
252dffc
Fix form mapping to uninitialized properties
ph-fritsche Apr 19, 2020
0575980
Ignore uninitialized properties when mapping to form
ph-fritsche Apr 19, 2020
6c3aaf2
Fix form mapping tests
ph-fritsche Apr 19, 2020
39b4abe
Be specific about ignored AccessExceptions when mapping to form
ph-fritsche Apr 19, 2020
19679dc
Fix test for old phpunit
ph-fritsche Apr 24, 2020
a975d5e
Fix test for symfony/property-access 2.8
ph-fritsche Apr 24, 2020
db718c0
Catch only UninitializedPropertyException when getting a value per Pr…
ph-fritsche May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test for old phpunit
  • Loading branch information
@ph-fritsche
ph-fritsche committed Apr 24, 2020
commit 19679dcbeb600a4164ff7b800599c2eff6664610
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Form/Tests/Extension/Core/DataMapper/PropertyPathMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public function testMapDataToFormsIgnoresUnmapped()
}

/**
* @requires PHP >= 7.4
* @requires PHP 7.4
*/
public function testMapDataToFormsIgnoresUninitializedProperties()
{
Expand Down Expand Up @@ -322,7 +322,7 @@ public function testMapFormsToDataIgnoresDisabled()
}

/**
* @requires PHP >= 7.4
* @requires PHP 7.4
*/
public function testMapFormsToUninitializedProperties()
{
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.