Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Serializer] add UidNormalizer #36406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Serializer] add UidNormalizer #36406

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eefeb39
UidNormalizer.
Apr 9, 2020
fcdb75c
More precise NotNormalizableValueException message.
Apr 10, 2020
63f5b3c
Use is_sub_class instead of ReflectionClass.
Apr 10, 2020
1058e1e
Change normalizer priority.
Apr 10, 2020
5edc132
Check if AbstractUid class exists.
Apr 10, 2020
abe7069
Minor fixes
May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor fixes
  • Loading branch information
Guillaume Pédelagrabe committed May 5, 2020
commit abe7069f314be9f141ff4b9488fc9099f6b0b813
6 changes: 3 additions & 3 deletions 6 src/Symfony/Component/Serializer/Normalizer/UidNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\Component\Uid\Ulid;
use Symfony\Component\Uid\Uuid;

class UidNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
final class UidNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
{
/**
* {@inheritdoc}
Expand Down Expand Up @@ -50,7 +50,7 @@ public function supportsNormalization($data, string $format = null)
public function denormalize($data, string $type, string $format = null, array $context = [])
{
if (!class_exists(AbstractUid::class)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed

throw new LogicException('Unable to execute this command as the Symfony Uid Component is not installed.');
throw new LogicException('You cannot use the "Symfony\Component\Serializer\Normalizer\UidNormalizer" as the Symfony Uid Component is not installed. Try running "composer require symfony/uid".');
}

try {
Expand All @@ -67,7 +67,7 @@ public function denormalize($data, string $type, string $format = null, array $c
*/
public function supportsDenormalization($data, string $type, string $format = null)
{
return is_subclass_of($type, AbstractUid::class) || AbstractUid::class === $type;
return is_a($type, AbstractUid::class, true);
}

/**
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.