Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DI] fix detecting short service syntax in yaml #36387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Apr 10, 2020
Merged

[DI] fix detecting short service syntax in yaml #36387

nicolas-grekas merged 1 commit into from
Apr 10, 2020

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 8, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

We do allow interfaces/classes as keys in arguments, yet the short syntax fails to know about those.

This fixes it, allowing one to use:

services:
    App\Foo:
        App\BarInterface: '@App\BarClass'

As a reminder, by-name is also allowed:

services:
    App\Foo: {
        $bar: '@App\BarClass'
    }

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Apr 8, 2020
@nicolas-grekas nicolas-grekas merged commit 6f19746 into symfony:4.4 Apr 10, 2020
@nicolas-grekas nicolas-grekas deleted the di-short-service branch April 12, 2020 12:06
This was referenced Apr 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug DependencyInjection Status: Needs Review

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.