Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[VarCloner] Cut Logger in dump #36372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

[VarCloner] Cut Logger in dump #36372

merged 1 commit into from
Apr 7, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 6, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I inject the logger in allmost all my services, and when I dump them
I got the logger and all its dependencies (processor, handler).
So I end up with the TokenStorage, the Session, some Web info...

IMHO, it's better to cut it.

@lyrixx lyrixx requested a review from nicolas-grekas April 7, 2020 09:55
@lyrixx
Copy link
Member Author

lyrixx commented Apr 7, 2020

Failures are not related

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2020
nicolas-grekas
nicolas-grekas approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can use the Psr one later on if we spot it's useful.

@lyrixx lyrixx merged commit 2d6327f into symfony:master Apr 7, 2020
@lyrixx lyrixx deleted the vardumper-log branch April 7, 2020 13:27
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed VarDumper
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.