[FWB][Serializer][Form][Validator] Uid integration #36317
Conversation
| $io = new SymfonyStyle($input, $output); | ||
|
|
||
| if (!class_exists(AbstractUid::class)) { | ||
| throw new \RuntimeException('Unable to execute this command as the Symfony Uid Component is not installed.'); |
There was a problem hiding this comment.
You should remove the service in the FrameworkExtension file when the AbstractUid doesn't exist instead of throwing an exception
| @@ -70,6 +70,12 @@ | ||
| <tag name="serializer.normalizer" priority="-890" /> | ||
| </service> | ||
|
|
||
| <service id="serializer.normalizer.uid" class="Symfony\Component\Serializer\Normalizer\UidNormalizer"> | ||
| <argument>%kernel.debug%</argument> |
There was a problem hiding this comment.
You should remove this argument
|
BTW, let me know when you have finished, i could test it |
|
i tend to prefer concrete UUID, ULID, ... validators. It allows for more fine grained control per type. E.g. ensure a specific UUID version maybe. I'd also think we should either support sf/uid as well as ramsey/uuid, but not an issue for me. Im not sure about the form type either, nor the console command. |
|
👍 for the serializer part I've not reviewed other parts. |
|
Hi @ro0NL @dunglas , that is the case, the Another possibility would be to have 2 options :
Or another possibility: 2 different constraints, 1 ULID constraint and 1 UUID constraint, with a What do you think is better? |
|
Maybe you could split the PR into smaller ones so that people can focus on the components they know best? |
i strongly prefer constraints per case. |
967e792 to
08c5b72
Compare
|
I've split this PR in 3 smaller PR, one per component:
I'm closing this PR. |
Integration of the Uid Component to Symfony stack: