[Uid] Improve the code #36267
Merged
[Uid] Improve the code #36267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sorry it is my first time doing this. Fixed the recommendation. |
nicolas-grekas
approved these changes
Mar 30, 2020
rosier
reviewed
Mar 30, 2020
rosier
reviewed
Mar 30, 2020
rosier
approved these changes
Mar 30, 2020
7842a80 to
e43f25d
Compare
e43f25d to
106c733
Compare
|
Thank you @nilmarsm86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the reuse of code, programing for extension and not for modification, create a Trait with similar behavior for getTime method in uuid types. Eliminate duplicate code in Uuid
Keep the same functionality, just improve a little the code, eliminating duplications and reusing some lines.