[Validator] Assert Valid with many groups #36216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Mar 27, 2020
| if ($constraint instanceof Composite) { | ||
| // instanceof Valid: In case of using a Valid constraint with many groups | ||
| // it makes a reference object get validated by each group | ||
| if ($constraint instanceof Composite || $constraint instanceof Valid) { |
There was a problem hiding this comment.
Indeed, looks good to me too.
This was referenced Mar 27, 2020
HeahDude
approved these changes
Mar 27, 2020
| if ($constraint instanceof Composite) { | ||
| // instanceof Valid: In case of using a Valid constraint with many groups | ||
| // it makes a reference object get validated by each group | ||
| if ($constraint instanceof Composite || $constraint instanceof Valid) { |
There was a problem hiding this comment.
Indeed, looks good to me too.
ogizanagi
approved these changes
Mar 28, 2020
|
Thank you @phucwan91. |
This was referenced Mar 30, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a reference object get validated by each group when using the Valid constraint with many groups