[Messenger] Add a \Throwable argument in RetryStrategyInterface methods #36185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
Mar 24, 2020
src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php
Outdated
Show resolved
Hide resolved
Tobion
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Please add a changelog note to https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Messenger/CHANGELOG.md
chalasr
approved these changes
Mar 27, 2020
|
Why didn't we go with the option of adding the argument to the existing interface, with a proper BC layer? It would make sense to me, don't you think so? |
|
Replacing the concrete method by a virtual one until 6.0? Our BC promise needs a patch :) |
|
@chalasr no need: just adding an
@Braxilior up to do it ? |
|
yes 👍 |
66b6eed to
90e7ceb
Compare
src/Symfony/Component/Messenger/Retry/MultiplierRetryStrategy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 2, 2020
|
@chalasr i do think the BC promise needs a patch in general. See symfony/symfony-docs#10504 for reference :) |
fabpot
approved these changes
Apr 4, 2020
|
Thank you @Braxilior. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to define new retry strategies based on the exceptions thrown during the last handling.