Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typo on deprecated parameter typehint on UPGRADE-5.1.md file #36177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jpjoao
Copy link
Contributor

@jpjoao jpjoao commented Mar 23, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets None
License MIT
Doc PR symfony/symfony-docs#13394

Fix typo.

@nicolas-grekas
Copy link
Member

good catch :)
src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md has the same typo, can you fix it please?

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 23, 2020
@nicolas-grekas nicolas-grekas force-pushed the typo-upgrade-51-RouteCollectionBuilder branch from a0c7398 to 4939d4c Compare March 23, 2020 12:07
@nicolas-grekas
Copy link
Member

Thank you @jpjoao.

@nicolas-grekas nicolas-grekas merged commit 9bcffd5 into symfony:master Mar 23, 2020
@jpjoao jpjoao deleted the typo-upgrade-51-RouteCollectionBuilder branch March 23, 2020 12:20
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.