[Routing] Fix some wrong localized routes tests #35926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c8ed68 to
c0d8b9c
Compare
c0d8b9c to
99ae55f
Compare
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #35855, theActually, the compilation is done after, so instead we need to set the new requirement in all tests to reflect the "reality"._localepath param is directly substituted so those tests are not valid cases anymore. Instead, the path directly contain the right locale.#35855 also causes a BC break on one case:
Previously, the generated route would be the
/en/fourchette. Now that the locale is hardcoded in the route path, it will always be/fr/fourchette. I changedfooto relevant words because it is easier to understand like that.