[ExpressionLanguage] Added expression language syntax validator #35849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119b381 to
623540b
Compare
|
ref #16323 |
7a7556d to
42e6a4e
Compare
|
Friendly ping @Andrej-in-ua |
|
Sorry for the delay, a slight change in priorities at work :( |
1ea6e34 to
8c88fb3
Compare
src/Symfony/Component/Validator/Constraints/ExpressionLanguageSyntax.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
fb43a13 to
c7b1f6b
Compare
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 4, 2020
fabpot
approved these changes
May 5, 2020
4e126ab to
a5cd965
Compare
|
Thank you @Andrej-in-ua. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal implementation #35700
The current solution is a compromise between support complexity and cleanliness.
I tried different solutions to the issue. A beautiful solution was obtained only with full duplication of the parser code. That is unacceptable because parser complexity is quite high.
The main problem in this solution is that nodes instances are created which are then not used. I do not think that linter can be a bottleneck and will greatly affect performance. If this is corrected, the parser code becomes a bunch of if's.
JFI: I did not added parsing without variable names, because this breaks caching and potential location for vulnerabilities.