Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Use Doctrine DBAL new Types::* constants #35819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

[Messenger] Use Doctrine DBAL new Types::* constants #35819

merged 1 commit into from
Feb 25, 2020

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Feb 21, 2020 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@fancyweb fancyweb requested a review from sroze as a code owner February 21, 2020 16:50
@ogizanagi ogizanagi added this to the 4.4 milestone Feb 21, 2020
@ogizanagi
Copy link
Contributor

This one should target 4.4. 4.3 reached end of bug fixes.

@fancyweb fancyweb force-pushed the messenger-types-constants branch from 60c6b9f to 11eedf4 Compare February 21, 2020 17:17
@fancyweb fancyweb changed the base branch from 4.3 to 4.4 February 21, 2020 17:17
@fancyweb
Copy link
Contributor Author

Thanks, I forgot about that 😅

Tobion
Tobion reviewed Feb 22, 2020
View reviewed changes
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php Outdated Show resolved Hide resolved
@OskarStark
Copy link
Contributor

OskarStark commented Feb 23, 2020 •
edited
Loading

You should update the target branch in the Pr header table as well 👍🏻

@fancyweb fancyweb force-pushed the messenger-types-constants branch 2 times, most recently from fbcd80b to 3ad91be Compare February 24, 2020 08:12
@fancyweb fancyweb force-pushed the messenger-types-constants branch from 3ad91be to f1fb159 Compare February 24, 2020 13:12
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 24, 2020
Merged
@fabpot
Copy link
Member

fabpot commented Feb 25, 2020

Thank you @fancyweb.

@fabpot fabpot merged commit 8a678f6 into symfony:4.4 Feb 25, 2020
@fancyweb fancyweb deleted the messenger-types-constants branch February 25, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Tobion Tobion Tobion left review comments

@fabpot fabpot fabpot approved these changes

@sroze sroze Awaiting requested review from sroze

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@fancyweb @ogizanagi @OskarStark @fabpot @nicolas-grekas @Tobion @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.