[Validator] Allow Sequentially constraints on classes + target guards #35815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
Feb 21, 2020
| @@ -178,6 +180,14 @@ public function addConstraint(Constraint $constraint) | ||
| throw new ConstraintDefinitionException(sprintf('The constraint "%s" cannot be put on classes.', \get_class($constraint))); | ||
| } | ||
|
|
||
| if ($constraint instanceof Sequentially || $constraint instanceof Compound) { |
There was a problem hiding this comment.
All could probably be added to this list, but could it lead to a BC break somehow?
There was a problem hiding this comment.
All could probably be added to this list
Why? It does not allow classes already thanks to the if before 🤔
There was a problem hiding this comment.
Wrong path. I meant in MemberMetadata 😄
There was a problem hiding this comment.
Hmm, what about a check against Composite instead? It may be needed for both then, and even target 3.4?
There was a problem hiding this comment.
Alright, let's consider this a bug fix. I'll move the second commit to another PR for 3.4
HeahDude
reviewed
Feb 21, 2020
src/Symfony/Component/Validator/Tests/Mapping/ClassMetadataTest.php
Outdated
Show resolved
Hide resolved
stof
approved these changes
Feb 24, 2020
chalasr
approved these changes
Feb 24, 2020
|
Thank you @ogizanagi. |
Merged
fabpot
added a commit
that referenced
this pull request
Aug 12, 2020
…ints (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add target guards for Composite nested constraints | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #35815 (review) <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Commits ------- a08ddf7 [Validator] Add target guards for Composite nested constraints
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Aug 12, 2020
…ints (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add target guards for Composite nested constraints | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix symfony/symfony#35815 (review) <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Commits ------- a08ddf7636 [Validator] Add target guards for Composite nested constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to limit this constraint to properties, so let's add classes as targets.
Additionally, let's ensure embedded constraints matches allowed targets too.